Updated recv_deadline documentation#1245
Open
ErisianArchitect wants to merge 1 commit intocrossbeam-rs:masterfrom
Open
Updated recv_deadline documentation#1245ErisianArchitect wants to merge 1 commit intocrossbeam-rs:masterfrom
ErisianArchitect wants to merge 1 commit intocrossbeam-rs:masterfrom
Conversation
…is non-empty and deadline is reached.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the behavior of
recv_deadlineis undocumented for the edge case where the channel is non-empty and the deadline has already been reached already. It has a bit of an unexpected behavior in that it ignores the deadline and returns the next message in the channel. I assume this behavior is intentional since you can check the deadline upstream, so I have updated the documentation to reflect the behavior.This is related to issue #975
Closes #975